Skip to content

drop module version #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexanderLanin merged 2 commits into from
Jan 13, 2026
Merged

drop module version #341

AlexanderLanin merged 2 commits into from
Jan 13, 2026
+3 −2

Conversation

@AlexanderLanin
Copy link
Member

@AlexanderLanin AlexanderLanin commented Jan 13, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 13, 2026 11:00
@github-actions
Copy link

github-actions bot commented Jan 13, 2026 •
edited
Loading

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 0d0eda2f-e50e-402f-b6cc-adc401d839d5
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (72 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (123 packages loaded, 2189 targets configured)

Analyzing: target //src:license-check (134 packages loaded, 2484 targets configured)

Analyzing: target //src:license-check (134 packages loaded, 2484 targets configured)

INFO: Analyzed target //src:license-check (137 packages loaded, 4500 targets configured).
[10 / 13] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 13.062s, Critical Path: 0.44s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

Copilot AI reviewed Jan 13, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request simplifies the module declaration in MODULE.bazel by dropping the explicit version number and compatibility level. The version is changed from "2.3.0" to "0.0.0" with a comment indicating that versioning will be handled through GitHub Releases instead.

Changes:

  • Removed the multi-line module() declaration with version "2.3.0" and compatibility_level = 2
  • Replaced it with a simplified single-line module() declaration with version "0.0.0"
  • Added a comment explaining that versioning is handled by GitHub Releases

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AlexanderLanin AlexanderLanin mentioned this pull request Jan 13, 2026
Closed
6 tasks
@github-actions
Copy link

github-actions bot commented Jan 13, 2026

The created documentation from the pull request is available at: docu-html

@AlexanderLanin AlexanderLanin merged commit dc490c8 into eclipse-score:main Jan 13, 2026
13 checks passed
@AlexanderLanin AlexanderLanin deleted the drop_version branch January 13, 2026 15:40
@github-project-automation github-project-automation bot moved this from Draft to Done in Infrastructure Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@MaximilianSoerenPollak MaximilianSoerenPollak MaximilianSoerenPollak approved these changes

@dcalavrezo-qorix dcalavrezo-qorix Awaiting requested review from dcalavrezo-qorix dcalavrezo-qorix is a code owner

@nradakovic nradakovic Awaiting requested review from nradakovic nradakovic is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Infrastructure
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexanderLanin @MaximilianSoerenPollak